PrachiPrakash commented on a change in pull request #7972:
URL: https://github.com/apache/pinot/pull/7972#discussion_r780801971
##########
File path:
pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java
##########
@@ -147,6 +147,9 @@ static void validate(PinotQuery pinotQuery)
private static void validateGroupByClause(PinotQuery pinotQuery)
throws SqlCompilationException {
if (pinotQuery.getGroupByList() == null) {
+ if (containsAggregateAndColsInSelectClause(pinotQuery)) {
+ throw new SqlCompilationException("Columns and Aggregate functions
can't co-exist without GROUP BY clause");
+ }
return;
}
// Sanity check group by query: All non-aggregate expression in selection
list should be also included in group
Review comment:
Cool makes sense would make the changes on the above lines. The only
thing being we might still need call to expressionContainsColumn(expr) to
allow the queries like below:
```
select 'foo' as foo, sum(c1) from bar
select upper('foo'), count(*) from bar
```
the Non-Aggregate Expression in the above doesn't have a column name hence
they must allowed(currently, this type of query are allowed and valid). let me
know if that okay?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
