amrishlal commented on a change in pull request #7916: URL: https://github.com/apache/pinot/pull/7916#discussion_r771145891
########## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/SwimLaneDocIdSetOperator.java ########## @@ -0,0 +1,111 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.operator; + +import com.google.common.base.Preconditions; +import java.util.Arrays; +import java.util.List; +import javax.annotation.Nullable; +import org.apache.pinot.common.request.context.ExpressionContext; +import org.apache.pinot.core.common.BlockDocIdIterator; +import org.apache.pinot.core.common.Operator; +import org.apache.pinot.core.operator.blocks.CombinedFilterBlock; +import org.apache.pinot.core.operator.blocks.DocIdSetBlock; +import org.apache.pinot.core.operator.blocks.FilterBlock; +import org.apache.pinot.core.operator.docidsets.FilterBlockDocIdSet; +import org.apache.pinot.core.operator.filter.CombinedFilterOperator; +import org.apache.pinot.core.plan.DocIdSetPlanNode; +import org.apache.pinot.segment.spi.Constants; + +/** + * DocIdSetOperator for a swimlane query plan. + */ +public class SwimLaneDocIdSetOperator extends DocIdSetOperator { + private static final String OPERATOR_NAME = "SwimLaneDocIdSetOperator"; + + private final CombinedFilterOperator _filterOperator; + private final ExpressionContext _expressionContext; + private final int _maxSizeOfDocIdSet; + + private FilterBlockDocIdSet _filterBlockDocIdSet; + private BlockDocIdIterator _blockDocIdIterator; + private int _currentDocId = 0; + + public SwimLaneDocIdSetOperator(CombinedFilterOperator filterOperator, ExpressionContext expressionContext, + int maxSizeOfDocIdSet) { + super(filterOperator, maxSizeOfDocIdSet); + + Preconditions.checkArgument(maxSizeOfDocIdSet > 0 && maxSizeOfDocIdSet <= DocIdSetPlanNode.MAX_DOC_PER_CALL); + _filterOperator = filterOperator; + _expressionContext = expressionContext; + _maxSizeOfDocIdSet = maxSizeOfDocIdSet; + } + + @Override + public String getOperatorName() { + return OPERATOR_NAME; + } + + @Override + public List<Operator> getChildOperators() { + return Arrays.asList(_filterOperator); + } + + @Nullable + @Override + public String toExplainString() { + return null; Review comment: I think this should be implemented so that this and any other operators being added can be properly displayed in EXPLAIN PLAN output. Also it would be great to add an aggregate filter query to `ExplainPlanQueriesTest.java`. ########## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/FilterableAggregationFunction.java ########## @@ -0,0 +1,139 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.query.aggregation.function; + +import java.util.List; +import java.util.Map; +import org.apache.pinot.common.request.context.ExpressionContext; +import org.apache.pinot.common.request.context.FilterContext; +import org.apache.pinot.common.utils.DataSchema; +import org.apache.pinot.core.common.BlockValSet; +import org.apache.pinot.core.query.aggregation.AggregationResultHolder; +import org.apache.pinot.core.query.aggregation.groupby.GroupByResultHolder; +import org.apache.pinot.segment.spi.AggregationFunctionType; + +/** + * Represents a filtered aggregation + */ +public class FilterableAggregationFunction implements + AggregationFunction<Object, Comparable> { + private AggregationFunction<Object, Comparable> _innerAggregationFunction; + private ExpressionContext _associatedExpressionContext; + private FilterContext _filterContext; + + public FilterableAggregationFunction(AggregationFunction aggregationFunction, + ExpressionContext associatedExpressionContext, FilterContext filterContext) { + _innerAggregationFunction = aggregationFunction; + _associatedExpressionContext = associatedExpressionContext; + _filterContext = filterContext; + } + + @Override + public AggregationFunctionType getType() { + return _innerAggregationFunction.getType(); + } + + @Override + public String getColumnName() { + return _innerAggregationFunction.getColumnName(); + } + + @Override + public String getResultColumnName() { + return _innerAggregationFunction.getResultColumnName(); + } + + @Override + public List<ExpressionContext> getInputExpressions() { + return _innerAggregationFunction.getInputExpressions(); + } + + @Override + public AggregationResultHolder createAggregationResultHolder() { + return _innerAggregationFunction.createAggregationResultHolder(); + } + + @Override + public GroupByResultHolder createGroupByResultHolder(int initialCapacity, int maxCapacity) { + return _innerAggregationFunction.createGroupByResultHolder(initialCapacity, maxCapacity); + } + + @Override + public void aggregate(int length, AggregationResultHolder aggregationResultHolder, + Map<ExpressionContext, BlockValSet> blockValSetMap) { + _innerAggregationFunction.aggregate(length, aggregationResultHolder, blockValSetMap); + } + + @Override + public void aggregateGroupBySV(int length, int[] groupKeyArray, GroupByResultHolder groupByResultHolder, + Map<ExpressionContext, BlockValSet> blockValSetMap) { + _innerAggregationFunction.aggregateGroupBySV(length, groupKeyArray, groupByResultHolder, + blockValSetMap); + } + + @Override + public void aggregateGroupByMV(int length, int[][] groupKeysArray, GroupByResultHolder groupByResultHolder, + Map<ExpressionContext, BlockValSet> blockValSetMap) { + _innerAggregationFunction.aggregateGroupByMV(length, groupKeysArray, groupByResultHolder, + blockValSetMap); + } + + @Override + public Object extractAggregationResult(AggregationResultHolder aggregationResultHolder) { + return _innerAggregationFunction.extractAggregationResult(aggregationResultHolder); + } + + @Override + public Object extractGroupByResult(GroupByResultHolder groupByResultHolder, int groupKey) { + return _innerAggregationFunction.extractGroupByResult(groupByResultHolder, groupKey); + } + + @Override + public Object merge(Object intermediateResult1, Object intermediateResult2) { + return _innerAggregationFunction.merge(intermediateResult1, intermediateResult2); + } + + @Override + public DataSchema.ColumnDataType getIntermediateResultColumnType() { + return _innerAggregationFunction.getIntermediateResultColumnType(); + } + + @Override + public DataSchema.ColumnDataType getFinalResultColumnType() { + return _innerAggregationFunction.getFinalResultColumnType(); + } + + @Override + public Comparable extractFinalResult(Object o) { + return _innerAggregationFunction.extractFinalResult(o); + } + + @Override + public String toExplainString() { + return null; Review comment: This one too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
