atris commented on a change in pull request #7916: URL: https://github.com/apache/pinot/pull/7916#discussion_r771094592
########## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/SwimLaneDocIdSetOperator.java ########## @@ -0,0 +1,111 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.operator; + +import com.google.common.base.Preconditions; +import java.util.Arrays; +import java.util.List; +import javax.annotation.Nullable; +import org.apache.pinot.common.request.context.ExpressionContext; +import org.apache.pinot.core.common.BlockDocIdIterator; +import org.apache.pinot.core.common.Operator; +import org.apache.pinot.core.operator.blocks.CombinedFilterBlock; +import org.apache.pinot.core.operator.blocks.DocIdSetBlock; +import org.apache.pinot.core.operator.blocks.FilterBlock; +import org.apache.pinot.core.operator.docidsets.FilterBlockDocIdSet; +import org.apache.pinot.core.operator.filter.CombinedFilterOperator; +import org.apache.pinot.core.plan.DocIdSetPlanNode; +import org.apache.pinot.segment.spi.Constants; + +/** + * DocIdSetOperator for a swimlane query plan. + */ +public class SwimLaneDocIdSetOperator extends DocIdSetOperator { + private static final String OPERATOR_NAME = "SwimLaneDocIdSetOperator"; + + private final CombinedFilterOperator _filterOperator; + private final ExpressionContext _expressionContext; + private final int _maxSizeOfDocIdSet; + + private FilterBlockDocIdSet _filterBlockDocIdSet; + private BlockDocIdIterator _blockDocIdIterator; + private int _currentDocId = 0; + + public SwimLaneDocIdSetOperator(CombinedFilterOperator filterOperator, ExpressionContext expressionContext, + int maxSizeOfDocIdSet) { + super(filterOperator, maxSizeOfDocIdSet); + + Preconditions.checkArgument(maxSizeOfDocIdSet > 0 && maxSizeOfDocIdSet <= DocIdSetPlanNode.MAX_DOC_PER_CALL); + _filterOperator = filterOperator; + _expressionContext = expressionContext; + _maxSizeOfDocIdSet = maxSizeOfDocIdSet; + } + + @Override + public String getOperatorName() { + return OPERATOR_NAME; + } + + @Override + public List<Operator> getChildOperators() { + return Arrays.asList(_filterOperator); + } + + @Nullable + @Override + public String toExplainString() { + return null; + } + + @Override + protected DocIdSetBlock getNextBlock() { + if (_currentDocId == Constants.EOF) { + return null; + } + + // Initialize filter block document Id set + if (_filterBlockDocIdSet == null) { + CombinedFilterBlock combinedFilterBlock = (CombinedFilterBlock) _filterOperator.nextBlock(); + FilterBlock filterBlock = combinedFilterBlock.getFilterBlock(_expressionContext); + + if (filterBlock == null) { + throw new IllegalStateException("Null block seen"); + } + + _filterBlockDocIdSet = filterBlock.getBlockDocIdSet(); + _blockDocIdIterator = _filterBlockDocIdSet.iterator(); + } + + int pos = 0; + int[] docIds = new int[DocIdSetPlanNode.MAX_DOC_PER_CALL]; + + for (int i = 0; i < _maxSizeOfDocIdSet; i++) { + _currentDocId = _blockDocIdIterator.next(); + if (_currentDocId == Constants.EOF) { + break; + } + docIds[pos++] = _currentDocId; + } + if (pos > 0) { + return new DocIdSetBlock(docIds, pos); + } else { + return null; + } Review comment: This is common code between DocIdSetIterator and this, and we should do the refactoring in a separate PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
