walterddr commented on a change in pull request #7839:
URL: https://github.com/apache/pinot/pull/7839#discussion_r765408223



##########
File path: 
pinot-core/src/main/java/org/apache/pinot/core/common/datatable/DataTableUtils.java
##########
@@ -107,6 +108,34 @@ public static DataTable buildEmptyDataTable(QueryContext 
queryContext)
     }
   }
 
+  public static DataTable buildMetadataOnlyDataTable(DataTable origDataTable) {

Review comment:
       doing this without replicating is dangerous unless we make the resulting 
`MetadataOnlyDataTable` and `DataOnlyDataTable` somehow immutable 
   
   e.g. you have additional object reference outside of the original DataTable 
that can mutate the content of itself. This can lead to unexpected behaviors




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to