walterddr commented on a change in pull request #7839:
URL: https://github.com/apache/pinot/pull/7839#discussion_r765310459
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/DataTable.java
##########
@@ -35,9 +35,16 @@
void addException(ProcessingException processingException);
+ void addException(int exceptionCode, String exceptionMsg);
+
Map<Integer, String> getExceptions();
- byte[] toBytes()
+ default byte[] toBytes()
+ throws IOException {
+ return toBytes(false);
+ }
+
+ byte[] toBytes(boolean isStrippingMetadata)
Review comment:
> Suggest adding 2 methods `DataTable toMetadataOnlyDataTable()` and
`DataTable toDataOnlyDataTable()` to the `DataTable` interface
what would be the appropriate way to make a toMetadataOnlyDataTable and
toDataOnlyDataTable work behind the scene? (if not replicating the object?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
