walterddr commented on a change in pull request #7692:
URL: https://github.com/apache/pinot/pull/7692#discussion_r743242597
##########
File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/DataTable.java
##########
@@ -33,7 +32,7 @@
// TODO: remove this when we stop supporting DataTable V2.
String EXCEPTION_METADATA_KEY = "Exception";
- void addException(ProcessingException processingException);
+ void addException(Exception processingException);
Review comment:
yes. at first I thought i would've been weird to add a generic for the
exception. But now that I think about it. the exception is part of the data
transferred between pinot components. it make sense to genericfy the exception
type to be handled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
