xiangfu0 commented on a change in pull request #7692:
URL: https://github.com/apache/pinot/pull/7692#discussion_r743178530
##########
File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/DataTable.java
##########
@@ -33,7 +32,7 @@
// TODO: remove this when we stop supporting DataTable V2.
String EXCEPTION_METADATA_KEY = "Exception";
- void addException(ProcessingException processingException);
+ void addException(Exception processingException);
Review comment:
Shall we consider make
```
public interface DataTable<E> {
...
void addException(E processingException);
```
Then in
```
DataTableImplV3<ProcessingException>
...
public void addException(ProcessingException processingException) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
