walterddr commented on a change in pull request #7497:
URL: https://github.com/apache/pinot/pull/7497#discussion_r719809688
##########
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/env/PinotConfiguration.java
##########
@@ -354,7 +356,12 @@ public long getProperty(String name, long defaultValue) {
* @return the property String value. Fallback to default value if missing.
*/
public String getProperty(String name, String defaultValue) {
- return getRawProperty(name, defaultValue).toString();
+ Object rawProperty = getRawProperty(name, defaultValue);
Review comment:
sounds good. although I think it should be addressed in separate PR as
TUNER_PACKAGE also uses this behavior. will sync with @daniellavoie
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
