Jackie-Jiang commented on a change in pull request #7497:
URL: https://github.com/apache/pinot/pull/7497#discussion_r719776364
##########
File path:
pinot-controller/src/test/java/org/apache/pinot/controller/ControllerTestUtils.java
##########
@@ -689,16 +689,23 @@ public static ControllerStarter getControllerStarter() {
properties.put("controller.segment.fetcher.auth.token", "*personal*");
properties.put("controller.admin.access.control.principals.user.password",
"*personal*");
+ properties.putAll(extraProperties);
+
return properties;
}
+ public static void startSuiteRun()
+ throws Exception {
+ startSuiteRun(Collections.emptyMap());
+ }
+
/**
* Initialize shared state for the TestNG suite.
*/
- public static void startSuiteRun()
+ public static void startSuiteRun(Map<String, Object> properties)
Review comment:
(nit)
```suggestion
public static void startSuiteRun(Map<String, Object> extraProperties)
```
##########
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/env/PinotConfiguration.java
##########
@@ -354,7 +356,12 @@ public long getProperty(String name, long defaultValue) {
* @return the property String value. Fallback to default value if missing.
*/
public String getProperty(String name, String defaultValue) {
- return getRawProperty(name, defaultValue).toString();
+ Object rawProperty = getRawProperty(name, defaultValue);
Review comment:
The behavior is not aligned with the `getProperty(String name)`. I feel
we should make them consistent to prevent unexpected behavior. You may sync
with @daniellavoie who contributed this file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
