snleee commented on a change in pull request #7368:
URL: https://github.com/apache/pinot/pull/7368#discussion_r718040518
##########
File path:
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/MergeRollupTaskGenerator.java
##########
@@ -110,17 +171,23 @@ public String getTaskType() {
public List<PinotTaskConfig> generateTasks(List<TableConfig> tableConfigs) {
String taskType = MergeRollupTask.TASK_TYPE;
List<PinotTaskConfig> pinotTaskConfigs = new ArrayList<>();
-
+ Set<String> candidateMergeTables = new HashSet<>();
for (TableConfig tableConfig : tableConfigs) {
if (!validate(tableConfig, taskType)) {
continue;
}
String offlineTableName = tableConfig.getTableName();
LOGGER.info("Start generating task configs for table: {} for task: {}",
offlineTableName, taskType);
+ candidateMergeTables.add(offlineTableName);
// Get all segment metadata
List<SegmentZKMetadata> allSegments =
_clusterInfoAccessor.getSegmentsZKMetadata(offlineTableName);
+ // Reset the watermark time if no segment found
+ if (allSegments.isEmpty()) {
Review comment:
As we discussed, we still want to keep this because we want to cover the
case when we deleted the segments for the existing table. I added more comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
