sajjad-moradi commented on a change in pull request #7267: URL: https://github.com/apache/pinot/pull/7267#discussion_r712396354
########## File path: pinot-server/src/main/java/org/apache/pinot/server/starter/helix/OffsetBasedConsumptionStatusChecker.java ########## @@ -0,0 +1,114 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.pinot.server.starter.helix; + +import java.util.HashSet; +import java.util.Set; +import org.apache.pinot.common.utils.LLCSegmentName; +import org.apache.pinot.core.data.manager.InstanceDataManager; +import org.apache.pinot.core.data.manager.realtime.LLRealtimeSegmentDataManager; +import org.apache.pinot.segment.local.data.manager.SegmentDataManager; +import org.apache.pinot.segment.local.data.manager.TableDataManager; +import org.apache.pinot.spi.config.table.TableType; +import org.apache.pinot.spi.stream.StreamPartitionMsgOffset; +import org.apache.pinot.spi.utils.builder.TableNameBuilder; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + + +/** + * This class is used at startup time to have a more accurate estimate of the catchup period in which no query execution + * happens and consumers try to catch up to the latest messages available in streams. + * To achieve this, every time status check is called - {@link #getNumConsumingSegmentsNotReachedTheirLatestOffset} - + * for each consuming segment, we check if segment's latest ingested offset has reached the latest stream offset that's + * fetched once at startup time. + */ +public class OffsetBasedConsumptionStatusChecker { + private static final Logger LOGGER = LoggerFactory.getLogger(OffsetBasedConsumptionStatusChecker.class); + + // constructor parameters + private final InstanceDataManager _instanceDataManager; + private final Set<String> _consumingSegments; + + // helper variable + private final Set<String> _caughtUpSegments = new HashSet<>(); + + public OffsetBasedConsumptionStatusChecker(InstanceDataManager instanceDataManager, Set<String> consumingSegments) { + _instanceDataManager = instanceDataManager; + _consumingSegments = consumingSegments; + } + + public int getNumConsumingSegmentsNotReachedTheirLatestOffset() { + for (String segName : _consumingSegments) { + if (_caughtUpSegments.contains(segName)) { + continue; + } + TableDataManager tableDataManager = getTableDataManager(segName); + if (tableDataManager == null) { + LOGGER.info("TableDataManager is not yet setup for segment {}. Will check consumption status later", segName); + continue; + } + SegmentDataManager segmentDataManager = null; + try { + segmentDataManager = tableDataManager.acquireSegment(segName); + if (segmentDataManager == null) { + LOGGER + .info("SegmentDataManager is not yet setup for segment {}. Will check consumption status later", segName); + continue; + } + if (!(segmentDataManager instanceof LLRealtimeSegmentDataManager)) { + // There's a possibility that a consuming segment has converted to a committed segment. If that's the case, + // segment data manager will not be of type LLRealtime. + LOGGER.info("Segment {} is already committed and is considered caught up.", segName); + _caughtUpSegments.add(segName); + continue; + } + LLRealtimeSegmentDataManager rtSegmentDataManager = (LLRealtimeSegmentDataManager) segmentDataManager; + StreamPartitionMsgOffset latestIngestedOffset = rtSegmentDataManager.getCurrentOffset(); + StreamPartitionMsgOffset latestStreamOffset = rtSegmentDataManager.getLatestStreamOffsetAtStartupTime(); + if (latestStreamOffset == null || latestIngestedOffset == null) { + LOGGER.info("Null offset found for segment {} - latest stream offset: {}, latest ingested offset: {}. " Review comment: Good suggestion, but we shouldn't need these logs. We should rely on the service status message. If we want to debug some specific partitions/tables, these logs will be used. Because of that, I think it's better to keep the code simple and don't add extra logic for logging purposes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
