sajjad-moradi commented on a change in pull request #7267:
URL: https://github.com/apache/pinot/pull/7267#discussion_r712393126
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java
##########
@@ -1363,6 +1369,16 @@ public LLRealtimeSegmentDataManager(SegmentZKMetadata
segmentZKMetadata, TableCo
}
_state = State.INITIAL_CONSUMING;
+ // fetch latest stream offset
+ try (StreamMetadataProvider metadataProvider = _streamConsumerFactory
+ .createPartitionMetadataProvider(_clientId, _partitionGroupId)) {
+ _latestStreamOffsetAtStartupTime = metadataProvider
+ .fetchStreamPartitionOffset(OffsetCriteria.LARGEST_OFFSET_CRITERIA,
/*maxWaitTimeMs*/5000);
+ } catch (Exception e) {
+ _segmentLogger.warn("Cannot fetch latest stream offset for clientId {}
and partitionGroupId {}", _clientId,
+ _partitionGroupId);
Review comment:
I'm not sure. The only thing that can go wrong is timeout and if we log
the exception, we'll clutter the logs with unhelpful stack trace of the
timeout. If you still think it's better to log the exception, I can add it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
