jackjlli commented on a change in pull request #7314:
URL: https://github.com/apache/pinot/pull/7314#discussion_r690822800
##########
File path:
pinot-plugins/pinot-input-format/pinot-avro-base/src/main/java/org/apache/pinot/plugin/inputformat/avro/AvroUtils.java
##########
@@ -332,6 +332,7 @@ private static void
extractSchemaWithComplexTypeHandling(org.apache.avro.Schema
default:
DataType dataType = AvroSchemaUtil.valueOf(fieldType);
addFieldToPinotSchema(pinotSchema, dataType, path, true, fieldTypeMap,
timeUnit);
+ break;
Review comment:
Is this break statement needed?
##########
File path:
pinot-plugins/pinot-stream-ingestion/pinot-kafka-0.9/src/test/java/org/apache/pinot/plugin/stream/kafka09/KafkaPartitionLevelConsumerTest.java
##########
@@ -56,45 +56,45 @@
public class KafkaPartitionLevelConsumerTest {
public class MockKafkaSimpleConsumerFactory implements
KafkaSimpleConsumerFactory {
- private String[] hosts;
- private int[] ports;
- private int[] partitionLeaderIndices;
- private int brokerCount;
- private int partitionCount;
- private String topicName;
- private BrokerEndPoint[] brokerArray;
+ private String[] _hosts;
+ private int[] _ports;
+ private int[] _partitionLeaderIndices;
+ private int _brokerCount;
+ private int _partitionCount;
+ private String _topicName;
+ private BrokerEndPoint[] _brokerArray;
public MockKafkaSimpleConsumerFactory(String[] hosts, int[] ports, long[]
partitionStartOffsets,
long[] partitionEndOffsets, int[] partitionLeaderIndices, String
topicName) {
Preconditions.checkArgument(hosts.length == ports.length);
- this.hosts = hosts;
- this.ports = ports;
- brokerCount = hosts.length;
+ this._hosts = hosts;
+ this._ports = ports;
Review comment:
Same here.
##########
File path:
pinot-plugins/pinot-input-format/pinot-avro/src/main/java/org/apache/pinot/plugin/inputformat/avro/KafkaAvroMessageDecoder.java
##########
@@ -189,21 +189,21 @@ private String hex(byte[] bytes) {
private static class SchemaFetcher implements Callable<Boolean> {
private org.apache.avro.Schema _schema;
- private URL url;
+ private URL _url;
private boolean _isSuccessful = false;
SchemaFetcher(URL url) {
- this.url = url;
+ this._url = url;
Review comment:
remove `this.`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
