Jackie-Jiang commented on a change in pull request #7314:
URL: https://github.com/apache/pinot/pull/7314#discussion_r690798478
##########
File path:
pinot-plugins/pinot-stream-ingestion/pinot-kinesis/src/test/java/org/apache/pinot/plugin/stream/kinesis/KinesisConsumerTest.java
##########
@@ -57,10 +57,10 @@
public static final String PLACEHOLDER = "DUMMY";
public static final int MAX_RECORDS_TO_FETCH = 20;
- private static KinesisConnectionHandler kinesisConnectionHandler;
- private static StreamConsumerFactory streamConsumerFactory;
- private static KinesisClient kinesisClient;
- private List<Record> recordList;
+ private static KinesisConnectionHandler _kinesisConnectionHandler;
Review comment:
These should not be static
##########
File path:
pinot-plugins/pinot-stream-ingestion/pinot-kinesis/src/test/java/org/apache/pinot/plugin/stream/kinesis/KinesisStreamMetadataProviderTest.java
##########
@@ -50,10 +50,10 @@
public static final String CLIENT_ID = "dummy";
public static final int TIMEOUT = 1000;
- private static KinesisConnectionHandler kinesisConnectionHandler;
- private KinesisStreamMetadataProvider kinesisStreamMetadataProvider;
- private static StreamConsumerFactory streamConsumerFactory;
- private static PartitionGroupConsumer partitionGroupConsumer;
+ private static KinesisConnectionHandler _kinesisConnectionHandler;
Review comment:
Remove `static`
##########
File path:
pinot-plugins/pinot-stream-ingestion/pinot-kafka-2.0/src/main/java/org/apache/pinot/plugin/stream/kafka20/KafkaStreamLevelStreamConfig.java
##########
@@ -129,7 +129,7 @@ public String getBootstrapServers() {
}
static {
Review comment:
Move this to the front?
##########
File path:
pinot-plugins/pinot-stream-ingestion/pinot-kafka-0.9/src/test/java/org/apache/pinot/plugin/stream/kafka09/KafkaPartitionLevelConsumerTest.java
##########
@@ -56,45 +56,45 @@
public class KafkaPartitionLevelConsumerTest {
public class MockKafkaSimpleConsumerFactory implements
KafkaSimpleConsumerFactory {
- private String[] hosts;
- private int[] ports;
- private int[] partitionLeaderIndices;
- private int brokerCount;
- private int partitionCount;
- private String topicName;
- private BrokerEndPoint[] brokerArray;
+ private String[] _hosts;
+ private int[] _ports;
+ private int[] _partitionLeaderIndices;
+ private int _brokerCount;
+ private int _partitionCount;
+ private String _topicName;
+ private BrokerEndPoint[] _brokerArray;
public MockKafkaSimpleConsumerFactory(String[] hosts, int[] ports, long[]
partitionStartOffsets,
long[] partitionEndOffsets, int[] partitionLeaderIndices, String
topicName) {
Preconditions.checkArgument(hosts.length == ports.length);
- this.hosts = hosts;
- this.ports = ports;
- brokerCount = hosts.length;
+ this._hosts = hosts;
Review comment:
Remove `this`
##########
File path:
pinot-plugins/pinot-file-system/pinot-adls/src/test/java/org/apache/pinot/plugin/filesystem/test/ADLSGen2PinotFSTest.java
##########
@@ -47,7 +47,13 @@
import org.testng.annotations.BeforeMethod;
import org.testng.annotations.Test;
-import static org.mockito.Mockito.*;
+import static org.mockito.Mockito.any;
Review comment:
Reformat
##########
File path:
pinot-plugins/pinot-stream-ingestion/pinot-kafka-2.0/src/main/java/org/apache/pinot/plugin/stream/kafka20/server/KafkaDataProducer.java
##########
@@ -50,7 +50,7 @@ public void init(Properties props) {
props.remove("request.required.acks");
props.remove("serializer.class");
try {
- this.producer = new KafkaProducer<>(props);
+ this._producer = new KafkaProducer<>(props);
Review comment:
Remove `this.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
