amrishlal commented on a change in pull request #7174:
URL: https://github.com/apache/pinot/pull/7174#discussion_r685680308



##########
File path: 
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/MinionInstancesCleanupTask.java
##########
@@ -54,8 +54,11 @@ public MinionInstancesCleanupTask(PinotHelixResourceManager 
pinotHelixResourceMa
         
controllerConf.getMinionInstancesCleanupTaskMinOfflineTimeBeforeDeletionInSeconds()
 * 1000L;
   }
 
+  /**
+   * @param filter Currently not used, but can be used to specify how this 
task should be run.
+   */
   @Override
-  protected void runTask() {
+  protected void runTask(String filter) {

Review comment:
       Looking into this...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to