amrishlal commented on a change in pull request #7174:
URL: https://github.com/apache/pinot/pull/7174#discussion_r684412586
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/MinionInstancesCleanupTask.java
##########
@@ -54,8 +54,11 @@ public MinionInstancesCleanupTask(PinotHelixResourceManager
pinotHelixResourceMa
controllerConf.getMinionInstancesCleanupTaskMinOfflineTimeBeforeDeletionInSeconds()
* 1000L;
}
+ /**
+ * @param filter Currently not used, but can be used to specify how this
task should be run.
+ */
@Override
- protected void runTask() {
+ protected void runTask(String filter) {
Review comment:
I thought about that, but the issue there is that if we put
`shouldRunForTable()` in base class, it may not apply to all subclasses? How
about adding a function `setAttribute(String key, String value)` in the base
class and this could be called as `setAttribute("tablename", tableName)`? For
now, the only attribute, we would allow is "tablename". This way there is no
strong association between table name and all the task classes which may not
use the table name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
