suddendust edited a comment on pull request #7237:
URL: https://github.com/apache/pinot/pull/7237#issuecomment-895186631
> Yeah, I had also mentioned the same edge case as mentioned by @npawar, we
should handle that.
@mayankshriv @npawar apologies this has been hanging around for a while, I
was a bit busy with the proposal for tiered storage. One question. When
`fieldsToRead` is empty or `null`, all columns are read by default:
```
@Override
public void init(File dataFile, @Nullable Set<String> fieldsToRead,
@Nullable RecordReaderConfig recordReaderConfig)
throws IOException {
```
In this case, to determine how many values a record contains, I'll have to
read an actual record from the file (I cannot rely on the configured header for
it is the header itself that we are verifying). But reading the file in
`init()` doesn't look like a nice idea. Would you recommend I do it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
