suddendust commented on a change in pull request #7237:
URL: https://github.com/apache/pinot/pull/7237#discussion_r683264466
##########
File path:
pinot-plugins/pinot-input-format/pinot-csv/src/test/java/org/apache/pinot/plugin/inputformat/csv/CSVRecordReaderTest.java
##########
@@ -103,4 +104,17 @@ protected void checkValue(RecordReader recordReader,
List<Map<String, Object>> e
}
Assert.assertFalse(recordReader.hasNext());
}
+
+ @Test
+ public void
whenConfiguredHeaderDoesNotContainConfiguredDelimiterThenExceptionShouldBeThrown()
{
Review comment:
Yes, actually I tend to name UTs in givenWhenThen format. This also
ensures people are not asserting on many different conditions. Will change to
keep consistent with Pinot's format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
