suddendust commented on pull request #7173: URL: https://github.com/apache/incubator-pinot/pull/7173#issuecomment-884492143
> also, in all the changes that you make, if you can prefix the configs with a comment like this: > // Deprecated as of 0.8.0 > Then, it is easy for someone to remove it a few releases down the road. > > Other than these minor comments, LGTM > > Thanks for your contribution Hey sure @mcvsubbu it is a pleasure to contribute to Pinot :) I will make these changes and raise another PR after updating the documentation. Thanks for your thorough review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
