suddendust commented on a change in pull request #7173: URL: https://github.com/apache/incubator-pinot/pull/7173#discussion_r674272705
########## File path: pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java ########## @@ -74,60 +76,115 @@ } public static class ControllerPeriodicTasksConf { + // frequency configs + @Deprecated public static final String RETENTION_MANAGER_FREQUENCY_IN_SECONDS = "controller.retention.frequencyInSeconds"; + public static final String RETENTION_MANAGER_FREQUENCY_PERIOD = "controller.retention.frequencyPeriod"; @Deprecated // The ValidationManager has been split up into 3 separate tasks, each having their own frequency config settings public static final String DEPRECATED_VALIDATION_MANAGER_FREQUENCY_IN_SECONDS = "controller.validation.frequencyInSeconds"; + @Deprecated Review comment: All deprecated configs have been prefixed with `DEPRECATED.` I will create a new ticket to do this in other places. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org