walterddr commented on pull request #7085: URL: https://github.com/apache/incubator-pinot/pull/7085#issuecomment-871001176
> Would suggest fixing it by rejecting the invalid table name / prefix / postfix instead of replacing the invalid characters just in the segment name. Having invalid character within table name can cause other issue even after fixing the segment name thanks for the review and I like this idea. just to clarify do we want to reject only or do you think we should also apply the auto-replace strategy to table name / prefix / postfix as well, like what I did in this PR for segment name? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
