Jackie-Jiang commented on a change in pull request #7085:
URL: https://github.com/apache/incubator-pinot/pull/7085#discussion_r660143563
##########
File path:
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/creator/name/NormalizedDateSegmentNameGenerator.java
##########
@@ -90,10 +90,14 @@ public String generateSegmentName(int sequenceId, @Nullable
Object minTimeValue,
// Include time value for APPEND push type
if (_appendPushType) {
- return JOINER.join(_segmentNamePrefix,
getNormalizedDate(Preconditions.checkNotNull(minTimeValue)),
- getNormalizedDate(Preconditions.checkNotNull(maxTimeValue)),
sequenceIdInSegmentName);
+ return JOINER
+ .join(_segmentNamePrefix,
getNormalizedDate(Preconditions.checkNotNull(minTimeValue)),
Review comment:
Please follow the code style:
https://docs.pinot.apache.org/developers/developers-and-contributors/code-setup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
