siddharthteotia commented on a change in pull request #7061:
URL: https://github.com/apache/incubator-pinot/pull/7061#discussion_r652253583



##########
File path: 
pinot-controller/src/main/java/org/apache/pinot/controller/util/ServerSegmentMetadataReader.java
##########
@@ -49,18 +53,20 @@ public ServerSegmentMetadataReader(Executor executor, 
HttpConnectionManager conn
    * @return list of segments and their metadata as a JSON string

Review comment:
       (nit) please add javadocs indicating how the column list is used and 
what is the default behavior




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to