mcvsubbu commented on a change in pull request #7061:
URL: https://github.com/apache/incubator-pinot/pull/7061#discussion_r652163897
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java
##########
@@ -591,7 +592,8 @@ private void deleteSegmentsInternal(String
tableNameWithType, List<String> segme
@ApiOperation(value = "Get the server metadata for all table segments",
notes = "Get the server metadata for all table segments")
public String getServerMetadata(
@ApiParam(value = "Name of the table", required = true)
@PathParam("tableName") String tableName,
- @ApiParam(value = "OFFLINE|REALTIME") @QueryParam("type") String
tableTypeStr) {
+ @ApiParam(value = "OFFLINE|REALTIME") @QueryParam("type") String
tableTypeStr,
+ @ApiParam(value = "Columns name", allowMultiple = true)
@QueryParam("columns") @DefaultValue("") List<String> columns) {
Review comment:
IIUC, this parameter can be specified multiple times, right? Not sure
how it will show up in swagger. Or, is it that we have a comma-separated column
list? In that case, I would suggest "Column names (comma separated)"
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java
##########
@@ -591,7 +592,8 @@ private void deleteSegmentsInternal(String
tableNameWithType, List<String> segme
@ApiOperation(value = "Get the server metadata for all table segments",
notes = "Get the server metadata for all table segments")
public String getServerMetadata(
@ApiParam(value = "Name of the table", required = true)
@PathParam("tableName") String tableName,
- @ApiParam(value = "OFFLINE|REALTIME") @QueryParam("type") String
tableTypeStr) {
+ @ApiParam(value = "OFFLINE|REALTIME") @QueryParam("type") String
tableTypeStr,
+ @ApiParam(value = "Columns name", allowMultiple = true)
@QueryParam("columns") @DefaultValue("") List<String> columns) {
Review comment:
```suggestion
@ApiParam(value = "Column name", allowMultiple = true)
@QueryParam("columns") @DefaultValue("") List<String> columns) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
