siddharthteotia commented on a change in pull request #6869: URL: https://github.com/apache/incubator-pinot/pull/6869#discussion_r630512196
########## File path: pinot-controller/src/main/java/org/apache/pinot/controller/recommender/rules/io/configs/SegmentSizeRecommendations.java ########## @@ -0,0 +1,84 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.pinot.controller.recommender.rules.io.configs; + +import com.fasterxml.jackson.annotation.JsonSetter; +import com.fasterxml.jackson.annotation.Nulls; + + +/** + * The recommendations proposed by SegmentSizeRule + */ +public class SegmentSizeRecommendations { + + private long numRowsPerSegment; + private long numSegments; + private long segmentSize; + private String message; + + public SegmentSizeRecommendations(long numRowsPerSegment, long numSegments, long segmentSize) { + this.numRowsPerSegment = numRowsPerSegment; + this.numSegments = numSegments; + this.segmentSize = segmentSize; + } + + public SegmentSizeRecommendations(String message) { + this.message = message; + } + + public SegmentSizeRecommendations() { + } + + public long getNumRowsPerSegment() { + return numRowsPerSegment; + } + + @JsonSetter(nulls = Nulls.SKIP) + public void setNumRowsPerSegment(long numRowsPerSegment) { + this.numRowsPerSegment = numRowsPerSegment; + } + + public long getNumSegments() { + return numSegments; + } + + @JsonSetter(nulls = Nulls.SKIP) + public void setNumSegments(long numSegments) { + this.numSegments = numSegments; + } + + public long getSegmentSize() { + return segmentSize; + } + + @JsonSetter(nulls = Nulls.SKIP) + public void setSegmentSize(long segmentSize) { + this.segmentSize = segmentSize; + } + + public String getMessage() { + return message; + } + + @JsonSetter(nulls = Nulls.SKIP) + public void setMessage(String message) { Review comment: As per our offline discussion, we should call this when rule is enabled but for realtime only table, the rule won't be run and the returned recommendations will have everything null except for message _"segment sizing for RT is done via RT provisioning rule_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
