siddharthteotia commented on a change in pull request #6869: URL: https://github.com/apache/incubator-pinot/pull/6869#discussion_r630483303
########## File path: pinot-controller/src/main/java/org/apache/pinot/controller/recommender/rules/io/params/RecommenderConstants.java ########## @@ -119,4 +127,5 @@ public static final int FIRST = 0; public static final int SECOND = 1; + public static final int DEFAULT_NUM_ROWS_IN_GENERATED_SEGMENT = 50_000; Review comment: I am guessing the reason to move this outside is because we use this in both RT provisioning rule and SegmentSizeRule ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org