siddharthteotia commented on a change in pull request #6869:
URL: https://github.com/apache/incubator-pinot/pull/6869#discussion_r626399144
##########
File path:
pinot-controller/src/test/java/org/apache/pinot/controller/recommender/TestConfigEngine.java
##########
@@ -229,6 +230,10 @@ void testPinotTablePartitionRule()
throws InvalidInputException, IOException {
loadInput("recommenderInput/PinotTablePartitionRuleInput.json");
+ // segment size recommendations get populated by SegmentSize Rule;
hard-coding the values here
+ _input._overWrittenConfigs.setSegmentSizeRecommendations(
+ new SegmentSizeRecommendations(/*numRows=*/1_000_000,
/*numSegments=*/4, /*segmentSize=*/1_000_000));
+
Review comment:
This also reinforces the point that it is better to always run this
rule. Wdyt ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
