siddharthteotia commented on a change in pull request #6869:
URL: https://github.com/apache/incubator-pinot/pull/6869#discussion_r626398530
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/recommender/rules/RulesToExecute.java
##########
@@ -160,9 +169,14 @@ public boolean isRecommendRealtimeProvisioning() {
return _recommendRealtimeProvisioning;
}
+ public boolean isRecommendSegmentSize() {
+ return _recommendSegmentSize;
+ }
+
// Be careful with the sequence, each rule can execute individually
// but a rule may depend on its previous rule when they both fired
public enum Rule {
+ SegmentSizeRule, // This rule must be the first rule. It provides segment
count, segment size, numRows in segments which are used in other rules. It also
adjust cardinality per segment for different columns.
Review comment:
I think we should always run this rule since computing CPS (used in all
subsequent rules) and numSegments (partition rule) are important.
So the user can still disable it via RulesToExecute as they can do for other
rules. But internally we always run to compute the information needed by other
rules. If disabled, we just don't return the recommendations (S, NRPS and
S_size)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
