siddharthteotia commented on a change in pull request #6876:
URL: https://github.com/apache/incubator-pinot/pull/6876#discussion_r626128003
##########
File path:
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/creator/SegmentGeneratorConfig.java
##########
@@ -262,6 +267,19 @@ private void
extractH3IndexConfigsFromTableConfig(TableConfig tableConfig) {
}
}
+ private void
extractNoDictionaryColumnCompressionCodecConfigsFromTableConfig(TableConfig
tableConfig) {
+ List<String> rawIndexColumns = new ArrayList<>();
+ List<FieldConfig> fieldConfigList = tableConfig.getFieldConfigList();
+ if (fieldConfigList != null) {
+ for (FieldConfig fieldConfig : fieldConfigList) {
+ if (fieldConfig.getEncodingType() == FieldConfig.EncodingType.RAW &&
fieldConfig.getNoDictionaryColumnCompressorCodec() != null) {
+ rawIndexColumns.add(fieldConfig.getName());
+ }
+ }
+ }
+ setRawIndexColumnCompressionType(tableConfig.getIndexingConfig(),
rawIndexColumns);
Review comment:
I think we should not use the old method here. Let it be there. Just
remove the call to it at line 280
Instead, we can probably do the following. Wdyt ?
`_rawIndexCreationColumns.add(fieldConfig.getName())` at line 276
`_rawIndexCompressionType.put(fieldConfig.getName(),
ChunkCompressionType.valueOf(fieldConfig.getNoDictionaryColumnCompressorCodec())`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
