GSharayu commented on a change in pull request #6876:
URL: https://github.com/apache/incubator-pinot/pull/6876#discussion_r626110847
##########
File path:
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/creator/SegmentGeneratorConfig.java
##########
@@ -262,6 +267,19 @@ private void
extractH3IndexConfigsFromTableConfig(TableConfig tableConfig) {
}
}
+ private void
extractNoDictionaryColumnCompressionCodecConfigsFromTableConfig(TableConfig
tableConfig) {
+ List<String> rawIndexColumns = new ArrayList<>();
+ List<FieldConfig> fieldConfigList = tableConfig.getFieldConfigList();
+ if (fieldConfigList != null) {
+ for (FieldConfig fieldConfig : fieldConfigList) {
+ if (fieldConfig.getEncodingType() == FieldConfig.EncodingType.RAW &&
fieldConfig.getNoDictionaryColumnCompressorCodec() != null) {
+ rawIndexColumns.add(fieldConfig.getName());
+ }
+ }
+ }
+ setRawIndexColumnCompressionType(tableConfig.getIndexingConfig(),
rawIndexColumns);
Review comment:
so, if the noDictinaryColumnMap is empty/null this indicates that no
column name to compressionType is set right? So you are right, the field config
map will not be set here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
