npawar commented on a change in pull request #6845: URL: https://github.com/apache/incubator-pinot/pull/6845#discussion_r623264857
########## File path: pinot-spi/src/main/java/org/apache/pinot/spi/config/table/ingestion/ComplexTypeHandlingConfig.java ########## @@ -0,0 +1,59 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.spi.config.table.ingestion; + +import com.fasterxml.jackson.annotation.JsonCreator; +import com.fasterxml.jackson.annotation.JsonProperty; +import com.fasterxml.jackson.annotation.JsonPropertyDescription; +import java.util.List; +import javax.annotation.Nullable; +import org.apache.pinot.spi.config.BaseJsonConfig; + + +/** + * Config related to handling complex type + */ +public class ComplexTypeHandlingConfig extends BaseJsonConfig { + public enum Mode { + NONE, FLATTEN_MAP + } + + @JsonPropertyDescription("The complex-type handling mode") + private final Mode _mode; + + @JsonPropertyDescription("The collections to unnest") + private final List<String> _unnestConfig; + + @JsonCreator + public ComplexTypeHandlingConfig(@JsonProperty(value = "mode") @Nullable Mode mode, Review comment: when can mode be null? If mode is null, the config wouldn't even be in the table config rt? ########## File path: pinot-spi/src/main/java/org/apache/pinot/spi/config/table/ingestion/IngestionConfig.java ########## @@ -43,15 +43,20 @@ @JsonPropertyDescription("Configs related to record transformation functions applied during ingestion") private final List<TransformConfig> _transformConfigs; + @JsonPropertyDescription("Config related to handling complex type") + private final ComplexTypeHandlingConfig _complexTypeHandlingConfig; Review comment: Thougths on renaming this to something simpler like "complexTypeConfig" or "flattenConfig"? ########## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java ########## @@ -483,6 +485,9 @@ private void processStreamEvents(MessageBatch messagesAndOffsets, long idlePipeS messagesAndOffsets.getMessageLengthAtIndex(index), reuse); if (decodedRow != null) { try { + if (_complexTypeTransformer != null) { + decodedRow = _complexTypeTransformer.transform(decodedRow); Review comment: this should just be part of the RecordTransformer returned by the CompositeTransformer#getDefaultTransformer rt? Why create a separate one? If it's separate, future developers always need to take the call on where to include this in the sequence. Also, we might introduce pluggable RecordTransformers. If this one is kept separate, it might cause confusion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
