siddharthteotia commented on a change in pull request #6845: URL: https://github.com/apache/incubator-pinot/pull/6845#discussion_r622346418
########## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/ComplexTypeTransformer.java ########## @@ -0,0 +1,184 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.segment.local.recordtransformer; + +import com.google.common.annotations.VisibleForTesting; +import java.util.ArrayList; +import java.util.Collection; +import java.util.Collections; +import java.util.HashSet; +import java.util.List; +import java.util.Map; +import javax.annotation.Nullable; +import org.apache.pinot.spi.config.table.TableConfig; +import org.apache.pinot.spi.config.table.ingestion.ComplexTypeHandlingConfig; +import org.apache.pinot.spi.data.readers.GenericRow; + + +public class ComplexTypeTransformer implements RecordTransformer { + private static final CharSequence DELIMITER = "."; + private final List<String> _collectionsToUnnest; + + public ComplexTypeTransformer(TableConfig tableConfig) { + if (tableConfig.getIngestionConfig() != null + && tableConfig.getIngestionConfig().getComplexTypeHandlingConfig() != null) { + _collectionsToUnnest = + tableConfig.getIngestionConfig().getComplexTypeHandlingConfig().getUnnestConfig() != null ? tableConfig + .getIngestionConfig().getComplexTypeHandlingConfig().getUnnestConfig() : new ArrayList<>(); + } else { + _collectionsToUnnest = new ArrayList<>(); + } + } + + @VisibleForTesting + public ComplexTypeTransformer(List<String> unnestCollections) { + _collectionsToUnnest = new ArrayList<>(unnestCollections); + Collections.sort(_collectionsToUnnest); + } + + public static boolean isComplexTypeHandlingEnabled(TableConfig tableConfig) { + if (tableConfig.getIngestionConfig() == null + || tableConfig.getIngestionConfig().getComplexTypeHandlingConfig() == null + || tableConfig.getIngestionConfig().getComplexTypeHandlingConfig().getMode() == null) { + return false; + } + return tableConfig.getIngestionConfig().getComplexTypeHandlingConfig().getMode() + != ComplexTypeHandlingConfig.Mode.NONE; + } + + @Nullable + @Override + public GenericRow transform(GenericRow record) { + flattenMap(record, new HashSet<>(record.getFieldToValueMap().keySet())); + for (String collection : _collectionsToUnnest) { + unnestCollection(record, collection); + } + return record; + } + + private GenericRow unnestCollection(GenericRow record, String column) { + if (record.getValue(GenericRow.MULTIPLE_RECORDS_KEY) == null) { + List<GenericRow> list = new ArrayList<>(); + unnestCollection(record, column, list); + record.putValue(GenericRow.MULTIPLE_RECORDS_KEY, list); + } else { + Collection<GenericRow> records = (Collection) record.getValue(GenericRow.MULTIPLE_RECORDS_KEY); + List<GenericRow> list = new ArrayList<>(); + for (GenericRow innerRecord : records) { + unnestCollection(innerRecord, column, list); + } + record.putValue(GenericRow.MULTIPLE_RECORDS_KEY, list); + } + return record; + } + + private void unnestCollection(GenericRow record, String column, List<GenericRow> list) { + Object value = record.removeValue(column); + if (value == null) { + // use the record itself + list.add(record); + return; + } else if (value instanceof Collection) { + if (((Collection) value).isEmpty()) { + // use the record itself + list.add(record); + } else { + for (Object obj : (Collection) value) { + GenericRow copy = flattenCollectionItem(record, obj, column); + list.add(copy); + } + } + } else if (value.getClass().isArray()) { + if (((Object[]) value).length == 0) { + // use the record itself + list.add(record); + } else { + for (Object obj : (Object[]) value) { + GenericRow copy = flattenCollectionItem(record, obj, column); + list.add(copy); + } + } + } + } + + private GenericRow flattenCollectionItem(GenericRow record, Object obj, String column) { + GenericRow copy = record.copy(); + if (obj instanceof Map) { + Map<String, Object> map = (Map<String, Object>) obj; + for (Map.Entry<String, Object> entry : new HashSet<>(map.entrySet())) { + String flattenName = concat(column, entry.getKey()); + copy.putValue(flattenName, entry.getValue()); + } + } else { + copy.putValue(column, obj); + } + return copy; Review comment: Since we are not recursing here, looks like list inside a list is not handled. What if obj is a list ? Example ``` "addresses": [ { "apt": 1012, "zip": 94404, "phones": [ { "phonenumber": 123456, "type": "mobile" }, { "phonenumber": 565676, "type": "work" }, { "phonenumber": 212123244, "type": "emergency" } ] }, { "apt": 1022, "zip": 94402, "phones": [ { "phonenumber": 212121, "type": "mobile" }, { "phonenumber": 32322, "type": "work" }, { "phonenumber": 232424, "type": "landline" } ] } ] ``` addresses = list (struct (apt, zip, phones (list (struct ( phone-number, type ))))) The above code won't flatten the phones list inside the addresses list. The above code will be called for each item in the root list addresses. Each item is a struct (in-memory hashmap). We go over the map assuming each entry is non-list which is true for apt and zip but not true for phones -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
