siddharthteotia commented on pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#issuecomment-809612014
> With this PR, we should resolve a couple of TODOs introduced in PR #6680 > > * Expose the serialization time through an API at the DataTable level and log it in [QueryScheduler](https://github.com/apache/incubator-pinot/pull/6710/files#diff-2bff83abd3f6e831acfe4b6d31a022f228710def4eea47db3929c6d90b3147ecR222). You need to serialize before the logging line. Currently it is after. > * Revisit [this](https://github.com/apache/incubator-pinot/pull/6710/files#diff-2bff83abd3f6e831acfe4b6d31a022f228710def4eea47db3929c6d90b3147ecR255). The execution cpu time is not yet serialized as part of metadata. May be we can just remove line 258. We can emit both costs separately. So have 2 server gauges. Similarly, log them in the QueryScheduler separately. But the serialized cost in the DataTable should be a single value (sum total of both exec cpu time cost and serialization cpu time cost) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
