[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

[GitBox]

mcvsubbu commented on a change in pull request #6710:
URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r603499342



##########
File path: 
pinot-core/src/main/java/org/apache/pinot/core/common/datatable/DataTableFactory.java
##########
@@ -32,7 +34,9 @@ public static DataTable getDataTable(ByteBuffer byteBuffer)
     int version = byteBuffer.getInt();
     switch (version) {
       case 2:
-        return new DataTableImplV2(byteBuffer);
+        return convertDataTableImplV2ToV3(new DataTableImplV2(byteBuffer));
+      case 3:

Review comment:
       can we use the VERSION_ constants defined




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org