chenboat commented on a change in pull request #6567:
URL: https://github.com/apache/incubator-pinot/pull/6567#discussion_r603442187
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/FileUploadDownloadClient.java
##########
@@ -551,6 +554,30 @@ public SimpleHttpResponse uploadSegment(URI uri, String
segmentName, File segmen
return uploadSegment(uri, segmentName, segmentFile, null, parameters,
DEFAULT_SOCKET_TIMEOUT_MS);
}
+ /**
+ * Upload segment with segment file using default settings. Include table
name and type as a request parameters.
+ *
+ * @param uri URI
+ * @param segmentName Segment name
+ * @param segmentFile Segment file
+ * @param tableName Table name with or without type suffix
+ * @param tableType Table type
+ * @return Response
+ * @throws IOException
+ * @throws HttpErrorStatusException
+ */
+ public SimpleHttpResponse uploadSegment(URI uri, String segmentName, File
segmentFile, String tableName,
+ TableType tableType)
+ throws IOException, HttpErrorStatusException {
+ // Add table name and type request parameters
+ NameValuePair tableNameValuePair = new
BasicNameValuePair(QueryParameters.TABLE_NAME, tableName);
+ NameValuePair tableTypeValuePair = new
BasicNameValuePair(QueryParameters.TABLE_TYPE, tableType.name());
+ List<NameValuePair> parameters = new ArrayList<>();
Review comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
