chenboat commented on pull request #6567: URL: https://github.com/apache/incubator-pinot/pull/6567#issuecomment-804394441
A new integration test UpsertTableSegmentUploadIntegrationTest is added to verify the uploaded segment is added to a realtime upsert enabled table correctly. The segment name used in the test does not follow llc segment convention but it is loaded successfully. The query result is good. I do quite understand why we should "Exclude uploaded segment from the processing". During segment load, the upsert table metadata should be processed based on the loaded segment, right? > Please take a look at `PinotLLCRealtimeSegmentManager` and ensure it works on uploaded segments: > > * Segment name for uploaded segment does not follow the llc segment name convention > * Exclude uploaded segment from the processing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
