siddharthteotia commented on a change in pull request #6710:
URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r599235536
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/common/datatable/DataTableImplV2V3.java
##########
@@ -344,6 +395,20 @@ public void addException(ProcessingException
processingException) {
return byteArrayOutputStream.toByteArray();
}
+ private byte[] serializePositionalData()
+ throws IOException {
+ ByteArrayOutputStream byteArrayOutputStream = new ByteArrayOutputStream();
+ DataOutputStream dataOutputStream = new
DataOutputStream(byteArrayOutputStream);
+
+ dataOutputStream.writeInt(_positionalData.length);
+ for (String entry : _positionalData) {
+ byte[] bytes = StringUtil.encodeUtf8(entry);
Review comment:
Some comments on the format here would be useful. We don't write the
enum constant itself. Just the value (length+bytes) corresponding to the
ordinal/position of the constant. Correct ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
