siddharthteotia commented on a change in pull request #6710:
URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r599226381
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/common/datatable/DataTableImplV2V3.java
##########
@@ -61,12 +65,15 @@
private final byte[] _variableSizeDataBytes;
private final ByteBuffer _variableSizeData;
private final Map<String, String> _metadata;
+ // Only V3 has _positionalData
+ private final String[] _positionalData;
/**
* Construct data table with results. (Server side)
*/
- public DataTableImplV2(int numRows, DataSchema dataSchema, Map<String,
Map<Integer, String>> dictionaryMap,
- byte[] fixedSizeDataBytes, byte[] variableSizeDataBytes) {
+ public DataTableImplV2V3(int version, int numRows, DataSchema dataSchema,
Review comment:
Are we passing version number to the constructor so that we can do
backward compatibility tests between V2 and V3 ? Other than tests, I don't see
why server should decide a version. It should always write the data table with
CURRENT_VERSION
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
