siddharthteotia commented on a change in pull request #6680:
URL: https://github.com/apache/incubator-pinot/pull/6680#discussion_r593793706
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/DataTable.java
##########
@@ -44,6 +44,7 @@
String REQUEST_ID_METADATA_KEY = "requestId";
String NUM_RESIZES_METADATA_KEY = "numResizes";
String RESIZE_TIME_MS_METADATA_KEY = "resizeTimeMs";
+ String THREAD_TIME_MS = "threadTimeMs";
Review comment:
Why should this be changed to microseconds?
The jmx api documentation says it returns nanosecond precision (but may not
be necessarily accurate). But we can't treat it as microseconds.
For example, if the returned value is
1000000. It is 1000 microseconds. If we treat the returned value as
microseconds, then we are increasing the value by 1000 times making it 1000ms.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
