siddharthteotia commented on pull request #6680: URL: https://github.com/apache/incubator-pinot/pull/6680#issuecomment-797884568
> > We should emit the metric like other server metrics and also see if the measurement can be made configurable via instance level config. > > This is a query level metric. If we emit it as BrokerMetrics/BrokerGauge, the number of metrics will explode. But we can expose it as a part of query response metadata, just like numServersQueried/numDocsScanned). I don't follow. I am not sure how BrokerMetric or BrokerGauge is involved here in the server context. From the server we should emit this query level metric and we should also include this as part of data table metadata (numDocsScanned etc) that is sent to the broker. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
