icefury71 commented on pull request #6641: URL: https://github.com/apache/incubator-pinot/pull/6641#issuecomment-791163748
Aah - good point. I can make that change. The map for the most part is just for better error message - the validation logic will still work. However, that will break for the current startree validation. On Thu, Mar 4, 2021 at 6:46 PM Xiaotian (Jackie) Jiang < notificati...@github.com> wrote: > *@Jackie-Jiang* commented on this pull request. > > We should not store columnNameToConfigMap as a map because the same > column can show up in multiple indexes, and override the previous entry > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/incubator-pinot/pull/6641#pullrequestreview-604758985>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAFRXV7SQAF6VLL7KOXXE63TCBA2DANCNFSM4YSRQTGQ> > . > -- Thanks and regards Chinmay Soman ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
