icefury71 commented on a change in pull request #6641:
URL: https://github.com/apache/incubator-pinot/pull/6641#discussion_r587710803



##########
File path: 
pinot-core/src/main/java/org/apache/pinot/core/util/TableConfigUtils.java
##########
@@ -371,6 +371,7 @@ private static void validateIndexingConfig(@Nullable 
IndexingConfig indexingConf
     }
     Map<String, String> columnNameToConfigMap = new HashMap<>();
     Set<String> noDictionaryColumnsSet = new HashSet<>();
+    String STAR_TREE_CONFIG_NAME = "StarTreeIndex Config";

Review comment:
       I thought about it - but this static variable will only be used within 
this method and nowhere else. So decided to let it be. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to