Jackie-Jiang commented on a change in pull request #6466:
URL: https://github.com/apache/incubator-pinot/pull/6466#discussion_r577303043
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/indexsegment/immutable/ImmutableSegmentLoader.java
##########
@@ -132,7 +135,7 @@ public static ImmutableSegment load(File indexDir,
IndexLoadingConfig indexLoadi
new
StarTreeIndexContainer(SegmentDirectoryPaths.findSegmentDirectory(indexDir),
segmentMetadata,
indexContainerMap, readMode);
}
-
+
Review comment:
(nit) revert
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/pruner/SegmentPrunerService.java
##########
@@ -38,11 +39,21 @@
public SegmentPrunerService(SegmentPrunerConfig config) {
int numPruners = config.numSegmentPruners();
- _segmentPruners = new ArrayList<>(numPruners);
+ _segmentPruners = new ArrayList<>(numPruners + 1);
Review comment:
We should always add `ValidSegmentPruner` as the first pruner?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
