apucher commented on a change in pull request #6418:
URL: https://github.com/apache/incubator-pinot/pull/6418#discussion_r557831263
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/transport/QueryRouter.java
##########
@@ -60,20 +84,23 @@ public AsyncQueryResponse submitQuery(long requestId,
String rawTableName,
long timeoutMs) {
assert offlineBrokerRequest != null || realtimeBrokerRequest != null;
+ // can prefer but not require TLS until all servers guaranteed to be on TLS
Review comment:
prefers != requires. the call to `toServerRoutingInstance()` below will
attempt to retrieve a ServerRoutingInstance with `tlsEnabled == true` but may
not be successful in doing so (if the server doesn't offer netty-tls yet). In
that case, we connect via unsecured netty (see QueryRouter:115)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
