mcvsubbu commented on pull request #6418: URL: https://github.com/apache/incubator-pinot/pull/6418#issuecomment-760422087
> > I will review this soon. Meanwhile, I believe it is totally worth it to test an upgrade/downgrade scenario. > > e.g. the controller is turned on to use https, but broker/server are not, and then the controller/broker is turned on, but server is not, and then finally the server is turned on to use https as well. > > In each of these scenarios, it is useful to test the following steps: add a table, add a segment, query it, delete the segment, and delete the table. You can write a simple script that you can run on each scenario. > > I know this is a bit of manual testing, but a few hours spent now, will save multiple issues in deployments, not to mention better user experience. It will also help in filling out the compat questions, and avoid problems when we turn on these configs. > > Thanks for the patience. > > I missed a couple of more tests : (1) execute a query from the console (tests the controller/broker path) (2) Execute the tablesize api on the controller (tests the controller/server path) Or, did I get the upgrade order wrong? Perhaps we need to upgrade to the new release, and turn on https in the order: server, broker and then controller. And then turn off http in any order amongst these components. Correct? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
