Jackie-Jiang commented on a change in pull request #6409:
URL: https://github.com/apache/incubator-pinot/pull/6409#discussion_r557795220
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/plan/FilterPlanNode.java
##########
@@ -93,27 +93,37 @@ public BaseFilterOperator run() {
}
}
+ /**
+ * H3 index can be applied iff:
+ * <ul>
+ * <li>Predicate is of type RANGE</li>
+ * <li>Left-hand-side of the predicate is an ST_Distance function</li>
+ * <li>One argument of the ST_Distance function is an identifier, the
other argument is an literal</li>
+ * <li>The identifier column has H3 index</li>
Review comment:
I see what you mean. There is a TODO on line 116 for that.
IMO, H3 index can only be applied to geography, but not geometry. Not sure
if we need geometry at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
