elonazoulay commented on a change in pull request #6426:
URL: https://github.com/apache/incubator-pinot/pull/6426#discussion_r556254573
##########
File path:
pinot-plugins/pinot-file-system/pinot-gcs/src/main/java/org/apache/pinot/plugin/filesystem/GcsPinotFS.java
##########
@@ -130,7 +131,7 @@ private String sanitizePath(String path) {
private URI getBase(URI uri) throws IOException {
try {
- return new URI(uri.getScheme(), uri.getHost(), null, null);
+ return new URI(SCHEME, uri.getHost(), DELIMITER, null);
Review comment:
Without this we get a uri creation error, this is done to guarantee that
we use the root directory, i.e. `gs://my_bucket/`, lmk what you think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
