elonazoulay commented on a change in pull request #6426:
URL: https://github.com/apache/incubator-pinot/pull/6426#discussion_r556254145
##########
File path:
pinot-plugins/pinot-file-system/pinot-gcs/src/main/java/org/apache/pinot/plugin/filesystem/GcsPinotFS.java
##########
@@ -204,7 +205,7 @@ public boolean delete(URI segmentUri, boolean forceDelete)
throws IOException {
LOGGER.info("Deleting uri {} force {}", segmentUri, forceDelete);
try {
if (!exists(segmentUri)) {
- return false;
+ return forceDelete;
Review comment:
Even if force delete is false? I thought of it as similar to `rm` vs `rm
-f`. But I can change it, lmk what you think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
