npawar commented on a change in pull request #6247: URL: https://github.com/apache/incubator-pinot/pull/6247#discussion_r525591155
########## File path: pinot-spi/src/main/java/org/apache/pinot/spi/config/table/ingestion/Batch.java ########## @@ -0,0 +1,67 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.spi.config.table.ingestion; + +import com.fasterxml.jackson.annotation.JsonCreator; +import com.fasterxml.jackson.annotation.JsonProperty; +import com.fasterxml.jackson.annotation.JsonPropertyDescription; +import java.util.List; +import java.util.Map; +import javax.annotation.Nullable; +import org.apache.pinot.spi.config.BaseJsonConfig; + + +/** + * Contains all configs related to the batch sources for ingestion. + */ +public class Batch extends BaseJsonConfig { + + @JsonPropertyDescription("Configs for all the batch sources to ingest from") + private final List<Map<String, String>> _batchConfigs; + + @JsonPropertyDescription("Push type APPEND or REFRESH") + private final String _segmentPushType; + + @JsonPropertyDescription("Push frequency HOURLY or DAILY") + private final String _segmentPushFrequency; + + @JsonCreator + public Batch(@JsonProperty("batchConfigs") @Nullable List<Map<String, String>> batchConfigs, Review comment: This one in particular should be allowed to be null i think. We have deprecated segmentPushType and segmentPushFrequency. That will make users set it in the BatchIngestionConfig. But not all users will have BatchConfigMaps (i.e. they could still be using push based model) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
