Jackie-Jiang commented on a change in pull request #6247:
URL: https://github.com/apache/incubator-pinot/pull/6247#discussion_r523287479
##########
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/IndexingConfig.java
##########
@@ -33,6 +34,7 @@
private List<String> _bloomFilterColumns;
private Map<String, BloomFilterConfig> _bloomFilterConfigs;
private String _loadMode;
+ @Deprecated // Moved to IngestionConfigs#Stream
Review comment:
Update the comment
##########
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/SegmentsValidationAndRetentionConfig.java
##########
@@ -91,6 +94,9 @@ public void setRetentionTimeValue(String retentionTimeValue) {
_retentionTimeValue = retentionTimeValue;
}
+ /**
+ * @deprecated Use <code>segmentPushFrequency</code> from {@link
IngestionConfig#getBatchIngestionConfig()}
Review comment:
(nit)
```suggestion
* @deprecated Use {@code segmentPushFrequency} from {@link
IngestionConfig#getBatchIngestionConfig()}
```
##########
File path:
pinot-core/src/test/java/org/apache/pinot/core/util/IngestionUtilsTest.java
##########
@@ -22,17 +22,27 @@
import com.google.common.collect.Sets;
import java.util.ArrayList;
import java.util.Arrays;
+import java.util.HashMap;
Review comment:
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
